Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose urls in Test.serverAddress using Node's url library #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tprobinson
Copy link

When making supertest calls with URLs that do not start with a slash, all sorts of wacky errors can result due to the way the serverAddress is composed via string concatenation.

Using Node's url library will give more reliable and error-resilient results.

@coveralls
Copy link

coveralls commented Jun 20, 2019

Pull Request Test Coverage Report for Build 410

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.297%

Totals Coverage Status
Change from base Build 404: 0.0%
Covered Lines: 138
Relevant Lines: 142

💛 - Coveralls

@tateexon
Copy link

Any chance of getting this merged? Would be very nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants